From 61fa43fb8d0f09d20687fe95c9caa47d82d354cf Mon Sep 17 00:00:00 2001 From: zaaarf Date: Wed, 12 Apr 2023 00:09:44 +0200 Subject: [PATCH] chore: constructors should be private --- .../ftbsc/lll/processor/tools/containers/ClassContainer.java | 4 ++-- .../ftbsc/lll/processor/tools/containers/FieldContainer.java | 4 ++-- .../lll/processor/tools/containers/MethodContainer.java | 5 +++-- 3 files changed, 7 insertions(+), 6 deletions(-) diff --git a/src/main/java/ftbsc/lll/processor/tools/containers/ClassContainer.java b/src/main/java/ftbsc/lll/processor/tools/containers/ClassContainer.java index 769651c..67ec26f 100644 --- a/src/main/java/ftbsc/lll/processor/tools/containers/ClassContainer.java +++ b/src/main/java/ftbsc/lll/processor/tools/containers/ClassContainer.java @@ -40,13 +40,13 @@ public class ClassContainer { public final Element elem; /** - * Public constructor. + * Private constructor, called from {@link #from(Annotation, Function, String, ProcessingEnvironment, ObfuscationMapper)}. * @param fqn the fully-qualified name of the target class * @param innerNames an array of Strings containing the path to the inner class, may be null * @param env the {@link ProcessingEnvironment} to be used to locate the class * @param mapper the {@link ObfuscationMapper} to be used, may be null */ - public ClassContainer(String fqn, String[] innerNames, ProcessingEnvironment env, ObfuscationMapper mapper) { + private ClassContainer(String fqn, String[] innerNames, ProcessingEnvironment env, ObfuscationMapper mapper) { //find and validate Element elem = env.getElementUtils().getTypeElement(fqn); diff --git a/src/main/java/ftbsc/lll/processor/tools/containers/FieldContainer.java b/src/main/java/ftbsc/lll/processor/tools/containers/FieldContainer.java index f46acc7..3f08201 100644 --- a/src/main/java/ftbsc/lll/processor/tools/containers/FieldContainer.java +++ b/src/main/java/ftbsc/lll/processor/tools/containers/FieldContainer.java @@ -55,14 +55,14 @@ public class FieldContainer { public final VariableElement elem; /** - * Public constructor. + * Private constructor, called from {@link #from(VariableElement, ProcessingEnvironment, ObfuscationMapper)}. * @param parent the {@link ClassContainer} representing the parent * @param name the fully-qualified name of the target field * @param descriptor the descriptor of the target field, may be null for verifiable fields * @param env the {@link ProcessingEnvironment} to perform the operation in * @param mapper the {@link ObfuscationMapper} to be used, may be null */ - public FieldContainer( + private FieldContainer( ClassContainer parent, String name, String descriptor, ProcessingEnvironment env, ObfuscationMapper mapper) { this.parent = parent; diff --git a/src/main/java/ftbsc/lll/processor/tools/containers/MethodContainer.java b/src/main/java/ftbsc/lll/processor/tools/containers/MethodContainer.java index adb6361..1892c28 100644 --- a/src/main/java/ftbsc/lll/processor/tools/containers/MethodContainer.java +++ b/src/main/java/ftbsc/lll/processor/tools/containers/MethodContainer.java @@ -54,7 +54,8 @@ public class MethodContainer { public final ExecutableElement elem; /** - * Public constructor. + * Private constructor, called from + * {@link #from(ExecutableElement, Target, Find, ProcessingEnvironment, ObfuscationMapper)}. * @param parent the {@link ClassContainer} representing the parent * @param name the fully-qualified name of the target method * @param descriptor the descriptor of the target method @@ -62,7 +63,7 @@ public class MethodContainer { * @param env the {@link ProcessingEnvironment} to perform the operation in * @param mapper the {@link ObfuscationMapper} to be used, may be null */ - public MethodContainer( + private MethodContainer( ClassContainer parent, String name, String descriptor, boolean strict, ProcessingEnvironment env, ObfuscationMapper mapper) { this.parent = parent;