fix: webfinger

too many special cases just search username and domain there are indexes

src/routes/activitypub/well_known.rs

@@ -102,56 +102,37 @@ pub async fn webfinger(State(ctx): State<Context>, Query(query): Query<Webfinger
 		.replace("acct:", "")
 		.split_once('@')
 	{
-		if domain == ctx.domain() {
+		let usr = model::actor::Entity::find()
-			// local user
+			.filter(model::actor::Column::PreferredUsername.eq(user))
-			let uid = ctx.uid(user);
+			.filter(model::actor::Column::Domain.eq(domain))
-			let usr = model::actor::Entity::find_by_ap_id(&uid)
+			.one(ctx.db())
-				.one(ctx.db())
+			.await?
-				.await?
+			.ok_or_else(UpubError::not_found)?;
-				.ok_or_else(UpubError::not_found)?;
 
-			Ok(JsonRD(JsonResourceDescriptor {
+		let expires = if domain == ctx.domain() {
-				subject: format!("acct:{user}@{domain}"),
+			// TODO configurable webfinger TTL, also 30 days may be too much???
-				aliases: vec![usr.id.clone()],
+			Some(chrono::Utc::now() + chrono::Duration::days(30))
-				links: vec![
-					JsonResourceDescriptorLink {
-						rel: "self".to_string(),
-						link_type: Some("application/ld+json".to_string()),
-						href: Some(usr.id),
-						properties: jrd::Map::default(),
-						titles: jrd::Map::default(),
-					},
-				],
-				expires: None,
-				properties: jrd::Map::default(),
-			}))
 		} else {
-			// remote user
+			// we are no authority on local users, this info should be considered already outdated,
-			let usr = model::actor::Entity::find()
+			// but can still be relevant, for example for our frontend
-				.filter(model::actor::Column::PreferredUsername.eq(user))
+			Some(chrono::Utc::now())
-				.filter(model::actor::Column::Domain.eq(domain))
+		};
-				.one(ctx.db())
+		
-				.await?
+		Ok(JsonRD(JsonResourceDescriptor {
-				.ok_or_else(UpubError::not_found)?;
+			subject: format!("acct:{user}@{domain}"),
-			
+			aliases: vec![usr.id.clone()],
-			Ok(JsonRD(JsonResourceDescriptor {
+			links: vec![
-				subject: format!("acct:{user}@{domain}"),
+				JsonResourceDescriptorLink {
-				aliases: vec![usr.id.clone()],
+					rel: "self".to_string(),
-				links: vec![
+					link_type: Some("application/ld+json".to_string()),
-					JsonResourceDescriptorLink {
+					href: Some(usr.id),
-						rel: "self".to_string(),
+					properties: jrd::Map::default(),
-						link_type: Some("application/ld+json".to_string()),
+					titles: jrd::Map::default(),
-						href: Some(usr.id),
+				},
-						properties: jrd::Map::default(),
+			],
-						titles: jrd::Map::default(),
+			properties: jrd::Map::default(),
-					},
+			expires,
-				],
+		}))
-				properties: jrd::Map::default(),
-				// we are no authority on local users, this info should be considered already outdated,
-				// but can still be relevant, for example for our frontend
-				expires: Some(chrono::Utc::now()),
-			}))
-		}
 	} else {
 		Err(StatusCode::UNPROCESSABLE_ENTITY.into())
 	}