hexedtech/codemp
3
0
Fork 0
mirror of https://github.com/hexedtech/codemp.git synced 2024-11-22 15:24:48 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

docs: added notes about leaking buffer id to client

Browse source
This commit is contained in:
əlemi 2024-02-07 01:15:32 +01:00
parent 948a1b4de5
commit 2fabec6e2e
1 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
proto/workspace.proto
View file

@ -15,7 +15,7 @@ service Workspace {
rpc ListBuffers (common.Empty) returns (files.BufferTree); rpc ListBuffers (common.Empty) returns (files.BufferTree);
rpc ListUsers (common.Empty) returns (common.IdentityList); rpc ListUsers (common.Empty) returns (common.IdentityList);
rpc ListBufferUsers (files.BufferNode) returns (common.IdentityList); //TODO discuss rpc ListBufferUsers (files.BufferNode) returns (common.IdentityList);
} }
message WorkspaceEvent { message WorkspaceEvent {
@ -45,6 +45,9 @@ message WorkspaceEvent {
} }
} }
// TODO this is very ugly because we can't just return a new token (which is already smelly but whatev), we also need to tell the underlying id so that
// the client can put it as metadata while attaching, because it can't really know the underlying id that the server is using for each buffer without
// parsing the token itself. meehhhhhh, this bleeds underlying implementation to the upper levels, how can we avoid this??
message BufferCredentials { message BufferCredentials {
required common.Identity id = 1; required common.Identity id = 1;
required auth.Token token = 2; required auth.Token token = 2;