docs: better wording in detach_buffer docs
Some checks failed
test / test-unit (push) Has been cancelled
test / test-beta (beta) (push) Has been cancelled
test / test-beta (nightly) (push) Has been cancelled
test / test-functional (push) Has been cancelled
test / test-build (java, macos-latest) (push) Has been cancelled
test / test-build (java, ubuntu-latest) (push) Has been cancelled
test / test-build (java, windows-latest) (push) Has been cancelled
test / test-build (js, macos-latest) (push) Has been cancelled
test / test-build (js, ubuntu-latest) (push) Has been cancelled
test / test-build (js, windows-latest) (push) Has been cancelled
test / test-build (luajit, macos-latest) (push) Has been cancelled
test / test-build (luajit, ubuntu-latest) (push) Has been cancelled
test / test-build (luajit, windows-latest) (push) Has been cancelled
test / test-build (py, macos-latest) (push) Has been cancelled
test / test-build (py, ubuntu-latest) (push) Has been cancelled
test / test-build (py, windows-latest) (push) Has been cancelled

This commit is contained in:
zaaarf 2024-11-03 20:11:36 +01:00
parent c1c9dea033
commit 888f7fd80c
No known key found for this signature in database
GPG key ID: 102E445F4C3F829B

View file

@ -185,10 +185,10 @@ impl Workspace {
///
/// This will stop and drop its [`buffer::Controller`].
///
/// Returns `true` if connectly dropped or wasn't present, `false` if dropped but wasn't last ref
///
/// If this method returns `false` you have a dangling ref, maybe just waiting for garbage
/// collection or maybe preventing the controller from being dropped completely
/// Returns `true` if it was connectly dropped or wasn't present, `false` if it was dropped but
/// wasn't the last existing reference to it. If this method returns `false` it means you have
/// a dangling reference somewhere. It may just be waiting for garbage collection, but as long
/// as it exists, it will prevent the controller from being completely dropped.
#[allow(clippy::redundant_pattern_matching)] // all cases are clearer this way
pub fn detach_buffer(&self, path: &str) -> bool {
match self.0.buffers.remove(path) {