zaaarf/upub
1
0
Fork 0
forked from alemi/upub
Code Pull requests Activity

docs: added notes on improving addressing expansion

Browse source
This commit is contained in:
əlemi 2024-06-22 05:41:37 +02:00
parent 16a10112a8
commit e6e13e95da
Signed by: alemi
GPG key ID: A4895B84D311642C
1 changed files with 10 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
upub/core/src/traits/address.rs
View file

@ -114,6 +114,16 @@ async fn address_to(ctx: &crate::Context, to: Vec<String>, aid: Option<i64>, oid
async fn expand_addressing(targets: Vec<String>, tx: &impl ConnectionTrait) -> Result<Vec<String>, DbErr> { async fn expand_addressing(targets: Vec<String>, tx: &impl ConnectionTrait) -> Result<Vec<String>, DbErr> {
let mut out = Vec::new(); let mut out = Vec::new();
for target in targets { for target in targets {
// TODO this is definitely NOT a reliable way to expand followers collections...
// we should add an index on following field in users and try to search for that: no
// guarantee that all followers collections end with 'followers'! once we get the actual
// user we can resolve their followers with the relations table
// ! NOTE THAT local users have followers set to NULL, either fill all local users followers
// field or manually check if it's local and then do the .ends_with("/followers")
// TODO should also expand /following
// TODO should probably expand audience too but it's not reachable anymore from here, should we
// count audience field too in the .addressed() trait? maybe pre-expand it because it's
// only used for groups anyway??
if target.ends_with("/followers") { if target.ends_with("/followers") {
let target_id = target.replace("/followers", ""); let target_id = target.replace("/followers", "");
let mut followers = crate::model::relation::Entity::followers(&target_id, tx) let mut followers = crate::model::relation::Entity::followers(&target_id, tx)